Enable feature to fix unstabilized #[bench]
#26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will cause this crate to become nightly only, #25 is a better fix that will still allow building on stable 1.38+. |
|
Inspired by the fix in cargo, missed the one you linked. Feel free to close if that one gets merged. |
|
ping @alexcrichton |
|
yeah if rust-lang/cargo#7198 was the inspiration, that's just tests... |
|
Sorry, but I am no longer maintaining this crate. |
|
But who is? Perhaps it should be transferred to rustasync since it is used by tide? |
We'd be happy to help share the maintenance burden if there's help needed! |
miller-time
added a commit
to miller-time/router
that referenced
this pull request
Aug 9, 2019
I guess route-recognizer is no longer maintained? My PR: http-rs/route-recognizer#25 Comment from Alex Crichton: http-rs/route-recognizer#26 (comment)
miller-time
added a commit
to miller-time/router
that referenced
this pull request
Aug 9, 2019
I guess route-recognizer is no longer maintained? My PR: http-rs/route-recognizer#25 Comment from Alex Crichton: http-rs/route-recognizer#26 (comment)
miller-time
added a commit
to miller-time/router
that referenced
this pull request
Aug 9, 2019
closes iron#148 - use patch for route-recognizer - add `dyn` to trait objects I guess route-recognizer is no longer maintained? My PR: http-rs/route-recognizer#25 Comment from Alex Crichton: http-rs/route-recognizer#26 (comment)
miller-time
added a commit
to miller-time/router
that referenced
this pull request
Aug 13, 2019
closes iron#148 - use patch for route-recognizer - add `dyn` to trait objects I guess route-recognizer is no longer maintained? My PR: http-rs/route-recognizer#25 Comment from Alex Crichton: http-rs/route-recognizer#26 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#62507